Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): update the dependencies mercurius for compatibility with fastify v5.x 🔥 #3407

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Dec 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number:

What is the new behavior?

Proposal:

  • Update the dependencies mercurius for compatibility with fastify v5.x 🔥

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Tony133 Tony133 force-pushed the chore/update-dependencies-for-fastify-v5 branch from 9091319 to 5f03554 Compare December 12, 2024 21:17
@Tony133 Tony133 force-pushed the chore/update-dependencies-for-fastify-v5 branch from 5f03554 to 534ed92 Compare December 12, 2024 21:23
@Tony133
Copy link
Contributor Author

Tony133 commented Dec 22, 2024

Tests fail due to this error: TypeError: A dynamic import callback was invoked without --experimental-vm-modules, very strange 🤔

@Tony133
Copy link
Contributor Author

Tony133 commented Dec 22, 2024

I think this is a problem with Jest.

Jest supports ECMAScript (ESM) modules from version 27.x, but full support for ESM, particularly dynamic imports, requires proper configuration, perhaps some configuration is missing? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant