Skip to content

chore: enhance test setup, improve compatibility, and fix security issues #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: enhance test setup, improve compatibility, and fix security issues #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aae04b2
refactor: replace coveralls with npm-run-all2 and improve build scripts
elvinbaghele Feb 14, 2025
1873c96
chore: improve test setup and security fixes
elvinbaghele Feb 14, 2025
1e897df
Updated Readme for the file
elvinbaghele Feb 14, 2025
529f552
4.0.5
elvinbaghele Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2019 Ashleigh Simonelli
Copyright (c) 2025 Elvin Baghele
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent


Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
28 changes: 14 additions & 14 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,33 @@
<p align="center"><img src="https://avatars1.githubusercontent.com/u/43827489?s=400&u=45ac0ac47d40b6d8f277c96bdf00244c10508aef&v=4"/></p>
<p align="center">
<img src="https://github.com/nestjsx/nestjs-typeorm-paginate/workflows/Tests/badge.svg"/>
<a href="https://www.npmjs.com/package/nestjs-typeorm-paginate"><img src="https://img.shields.io/npm/v/nestjs-typeorm-paginate.svg"/></a>
<a href='https://coveralls.io/github/nestjsx/nestjs-typeorm-paginate?branch=master'><img src='https://coveralls.io/repos/github/nestjsx/nestjs-typeorm-paginate/badge.svg?branch=master' alt='Coverage Status' /></a>
<img src="https://github.com/nestjsx/tekvo-nest-typeorm-paginate/workflows/Tests/badge.svg"/>
<a href="https://www.npmjs.com/package/tekvo-nest-typeorm-paginate"><img src="https://img.shields.io/npm/v/tekvo-nest-typeorm-paginate.svg"/></a>
<a href='https://coveralls.io/github/nestjsx/tekvo-nest-typeorm-paginate?branch=master'><img src='https://coveralls.io/repos/github/nestjsx/tekvo-nest-typeorm-paginate/badge.svg?branch=master' alt='Coverage Status' /></a>
<img src="https://camo.githubusercontent.com/a34cfbf37ba6848362bf2bee0f3915c2e38b1cc1/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f5052732d77656c636f6d652d627269676874677265656e2e7376673f7374796c653d666c61742d737175617265" />
<a href="https://github.com/juliandavidmr/awesome-nestjs#components--libraries"><img src="https://raw.githubusercontent.com/nestjsx/crud/master/img/awesome-nest.svg?sanitize=true" alt="Awesome Nest" /></a>
<a href="https://github.com/nestjs/nest"><img src="https://raw.githubusercontent.com/nestjsx/crud/master/img/nest-powered.svg?sanitize=true" alt="Nest Powered" /></a>
<a href="https://packagequality.com/#?package=nestjs-typeorm-paginate"><img src="https://packagequality.com/shield/nestjs-typeorm-paginate.svg" /></a>
<a href="https://packagequality.com/#?package=tekvo-nest-typeorm-paginate"><img src="https://packagequality.com/shield/tekvo-nest-typeorm-paginate.svg" /></a>
<a href="https://www.npmjs.com/org/nestjsx">
<img src="https://img.shields.io/npm/dt/nestjs-typeorm-paginate.svg" alt="npm downloads" />
<img src="https://img.shields.io/npm/dt/tekvo-nest-typeorm-paginate.svg" alt="npm downloads" />
</a>
</p>

<h1 align="center">Nestjs Typeorm paginate</h1>
<h1 align="center">Tekvo - Nestjs Typeorm paginate</h1>
Comment on lines -3 to +15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary to change the package name and links

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent


Pagination helper method for TypeORM repositories or queryBuilders with strict typings

## Install

```bash
$ yarn add nestjs-typeorm-paginate
$ yarn add tekvo-nest-typeorm-paginate
```
or
```bash
$ npm i nestjs-typeorm-paginate
$ npm i tekvo-nest-typeorm-paginate
```

> If you're using typeorm^0.2.6 please use nestjs-typeorm-paginate^3.2.0
> For typeorm^0.3.0 please use nestjs-typeorm-paginate^4.0.0
> If you're using typeorm^0.2.6 please use tekvo-nest-typeorm-paginate^3.2.0
> For typeorm^0.3.0 please use tekvo-nest-typeorm-paginate^4.0.4
Comment on lines -22 to +30
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary to change package links and name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent


## Usage

Expand All @@ -44,7 +44,7 @@ import {
paginate,
Pagination,
IPaginationOptions,
} from 'nestjs-typeorm-paginate';
} from 'tekvo-nest-typeorm-paginate';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent


@Injectable()
export class CatService {
Expand All @@ -70,7 +70,7 @@ import {
paginate,
Pagination,
IPaginationOptions,
} from 'nestjs-typeorm-paginate';
} from 'tekvo-nest-typeorm-paginate';

@Injectable()
export class CatService {
Expand All @@ -94,7 +94,7 @@ export class CatService {
import { Controller, DefaultValuePipe, Get, ParseIntPipe, Query } from '@nestjs/common';
import { CatService } from './cat.service';
import { CatEntity } from './cat.entity';
import { Pagination } from 'nestjs-typeorm-paginate';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same again

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to use this package, but since updates were missing, I created another package. However, I didn't realize the changes also got reflected in this PR. I will push a new commit on this one to revent

import { Pagination } from 'tekvo-nest-typeorm-paginate';

@Controller('cats')
export class CatsController {
Expand All @@ -114,7 +114,7 @@ export class CatsController {
}
```

> If you use `ParseIntPipe` on the query params (as in the example), don't forget to also add `DefaultValuePipe`. See [issue 517](https://github.com/nestjsx/nestjs-typeorm-paginate/issues/517) for more info.
> If you use `ParseIntPipe` on the query params (as in the example), don't forget to also add `DefaultValuePipe`. See [issue 517](https://github.com/nestjsx/tekvo-nest-typeorm-paginate/issues/517) for more info.

> the `route` property of the paginate options can also be the short version of an absolute path , In this case, it would be `/cats` instead of `http://cats.com/cats`

Expand Down
Binary file added database.sqlite
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ var __createBinding = (this && this.__createBinding) || (Object.create ? (functi
var __exportStar = (this && this.__exportStar) || function(m, exports) {
for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
};
exports.__esModule = true;
Object.defineProperty(exports, "__esModule", { value: true });
__exportStar(require("./dist"), exports);
Loading
Loading