Added Niagara TAP 3225-PTC-2 #3526
Conversation
Guibi1
force-pushed
the
niagara-3225-ptc-2
branch
from
ebde9e7 to
6698bc7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Niagara passive TAP device (3225-PTC-2) with support for two single-width TAP modules. The device is configured as a 1U passive fiber optic network TAP with 25 module slots.
- Adds a new 25-slot passive TAP chassis device
- Includes two single-width TAP module definitions for different fiber types
- Provides modules for both 850nm multimode (SR) and 1310nm/1550nm single mode (LR) configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| device-types/Niagara/3225-PTC-2.yaml | Defines the main 25-slot TAP chassis device |
| module-types/Niagara/3211-S-SR-50-50.yaml | Single-width TAP module for 850nm multimode fiber |
| module-types/Niagara/3211-S-LR-50-50.yaml | Single-width TAP module for 1310nm/1550nm single mode fiber |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| model: Network TAP Passive Fiber Optics Module Single Width 1310nm 1550nm 50/50 | ||
| part_number: 3211-S-LR-50/50 | ||
| comments: '[TAP Datasheet](https://info.niagaranetworks.com/hubfs/Product%20Data%20Sheets/3225/3225.pdf)' | ||
| interfaces: |
There was a problem hiding this comment.
If these are passive taps then they won't have 100GB interfaces they will just be LC ports
There was a problem hiding this comment.
Yes they are passive but I can't put lc as an interface type. Should I move them to the front/rear ports?
There was a problem hiding this comment.
Yes these should be probably front ports linked to the same rear ports, I guess is the best way
| part_number: 3211-S-SR-50/50 | ||
| comments: '[TAP Datasheet](https://info.niagaranetworks.com/hubfs/Product%20Data%20Sheets/3225/3225.pdf)' | ||
| interfaces: | ||
| - name: Port/{module}/A_Monitor |
There was a problem hiding this comment.
Again if these are passive they should just be LC ports
harryajc
added
the
status: revisions needed
| model: Network TAP Passive Fiber Optics Module Single Width 1310nm 1550nm 50/50 | ||
| part_number: 3211-S-LR-50/50 | ||
| comments: '[TAP Datasheet](https://info.niagaranetworks.com/hubfs/Product%20Data%20Sheets/3225/3225.pdf)' | ||
| interfaces: |
There was a problem hiding this comment.
Yes these should be probably front ports linked to the same rear ports, I guess is the best way
2 participants
Added Niagara passive TAP 3225-PTC-2 with two single width taps.