Add a schema for values validation #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoColomb
force-pushed
the
leo/feat/schema
branch
2 times, most recently
from
406d750
to
7c3feeb
Compare
|
Upgrade check failure is directly linked to the type change: the validation of values before upgrades is failing. https://github.com/netbox-community/netbox-chart/actions/runs/10782731200/job/29903300695?pr=334#step:7:107 In theory, this should request a major version bump. |
RangerRick
approved these changes
Sep 11, 2024
|
Love having a schema at least, been wanting to do that. |
|
@RangerRick Happy to help 😁 |
|
Yeah, well, I was planning on merging it anyway, but i guess our permissions lockdown means I can't, lol. I'll look at it tomorrow. |
LeoColomb
force-pushed
the
leo/feat/schema
branch
from
672bcbc
to
0d04806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
values.schema.jsonfile.It is the standard schema file for values validation.
The proposed version is relatively naive, auto-generated and without further customization.