Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #18241 - Script results log_threshold should default to Default #18501

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Fixes: #18241 - Script results log_threshold should default to Default #18501

merged 5 commits into from
Feb 6, 2025

Conversation

renatoalmeidaoliveira
Copy link
Collaborator

Fixes: #18241 - Script results log_threshold should default to Default

  • Changes the LogLevelChoices Choices order, putting LOG_DEBUG in the last position.
  • Changes script_result.html dropdown to add the string (All) only to the last possition following the new LogLevelChoices order
  • Changes ScriptResultView get method to return log_threshold with LOG_DEFAULT instead of LOG_DEBUG

@DanSheps DanSheps requested a review from bctiemann January 27, 2025 18:42
@jeremystretch jeremystretch merged commit efa939d into netbox-community:main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bctiemann bctiemann bctiemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script results log_threshold should default to Default
3 participants
@renatoalmeidaoliveira @bctiemann @jeremystretch