chore: remove duplicated code in orb backends #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the consistency and code reuse across different backend components (
device discovery
,network discovery
, andopen telemetry
). The changes primarily focus on updating the way requests are made to backend services and replacing theinterface{}
type with the more modernany
type.Improvements to request handling and code reuse:
agent/backend/devicediscovery/device_discovery.go
: Replaced custom request handling logic withbackend.CommonRequest
and updated theConfigure
,GetCapabilities
,ApplyPolicy
, andRemovePolicy
methods to useany
instead ofinterface{}
. [1] [2] [3] [4] [5] [6] [7] [8]agent/backend/devicediscovery/utils.go
: Removed thegetProcRunningStatus
andrequest
functions in favor of usingbackend.CommonRequest
.Consistency improvements in network discovery:
agent/backend/networkdiscovery/network_discovery.go
: Similar updates as in device discovery, including replacinginterface{}
withany
and usingbackend.CommonRequest
for making requests. [1] [2] [3] [4] [5] [6] [7] [8]agent/backend/networkdiscovery/utils.go
: Removed thegetProcRunningStatus
andrequest
functions, as they are now redundant.Updates in open telemetry backend:
agent/backend/otel/otel.go
: Updated theConfigure
,GetCapabilities
, and other methods to useany
instead ofinterface{}
and replaced custom request handling withbackend.CommonRequest
. [1] [2] [3] [4] [5]These changes enhance the maintainability and readability of the code by standardizing request handling and modernizing type usage across different backend components.