rm service discovery sidecar for Netdata v2.2+ #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witalisoft
previously approved these changes
Jan 3, 2025
M4itee
requested changes
Jan 3, 2025
Contributor
M4itee
left a comment
M4itee
left a comment
There was a problem hiding this comment.
I'm ok with the change but please keep yaml extensions the same - k8s.yml stands out from other .yaml's
Member
Author
|
The existing configuration has a https://github.com/netdata/helmchart/blob/master/charts/netdata/sdconfig/child.yml |
ilyam8
commented
Jan 3, 2025
Member
Author
|
@M4itee can you answer to #459 (comment)? |
ilyam8
changed the title
Member
Author
|
Changed version check to < 2.2 as we decided not to do a major release. |
M4itee
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service-discovery sidecar is no longer needed as its functionality is built into go.d.plugin.
This change was announced in v2.1.0 deprecation notice.