Deps upgrade + fix compile time errors #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades various dependency versions and fixes compile-time errors by refactoring mapping functions and introducing safe conversion handling. Key changes include:
- Upgraded dependency versions in both pubspec.yaml files.
- Added a new enum (CodeFileGeneratedType) to classify generated code types.
- Updated AutoMappr mapping functions to include an optional onMappingError parameter and a new _safeConvert helper.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Upgraded dependency versions to address compile-time and compatibility issues. |
| lib/model/code_file_generated_type.dart | Introduced a new enum for generated code types. |
| example/pubspec.yaml | Updated dependency and SDK versions for example usage. |
| example/lib/user_mappr.auto_mappr.dart | Refactored conversion methods to incorporate safe error handling. |
| example/lib/models/freezed_union.freezed.dart | Updated generated code formatting and refactored copyWith and equality logic. |
| @@ -1,0 +1,4 @@ | |||
| enum CodeFileGeneratedType { | |||
| import, | |||
There was a problem hiding this comment.
The enum value 'import' is a reserved keyword in Dart and may cause compile-time errors. Consider renaming it to a non-reserved identifier such as 'importFile'.
Suggested change
| import, | |
| importFile, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.