[NAE 2112] Email plugin #316
Conversation
- extracted email functionality to email plugin
WalkthroughThis change set removes all mail-related functionality from the application. It deletes all code, configuration, interfaces, and tests involved in email sending, mail attempt tracking, and email template management. All endpoints and methods responsible for sending registration, invitation, and password reset emails are removed or commented out. Associated documentation and test files are also deleted or updated accordingly. Changes
Sequence Diagram(s)No sequence diagrams are generated because the changes solely remove or comment out mail-related functionality and do not introduce or alter any control flow or feature logic. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🔭 Outside diff range comments (1)
application-engine/src/test/groovy/com/netgrif/application/engine/auth/AuthenticationControllerTest.groovy (1)
122-122: 💡 Verification agent🧩 Analysis chain
Critical compilation error: EmailType reference without import.
The code references
EmailType.REGISTRATION.getSubject()but according to the changes, theEmailTypeimport has been removed. This will cause a compilation failure.Either add the missing import or remove/update this test assertion to not depend on
EmailType.
🏁 Script executed:
#!/bin/bash # Verify if EmailType is still available in the codebase fd -t f -e java -e groovy | xargs grep -l "enum EmailType\|class EmailType" | head -5 rg "EmailType" application-engine/src/test/groovy/com/netgrif/application/engine/auth/AuthenticationControllerTest.groovy -A 2 -B 2Length of output: 404
Fix missing EmailType reference in AuthenticationControllerTest
The test at line 122 still references
EmailType, but that enum no longer exists in the codebase. This will cause a compilation failure. Please update or remove this assertion to use the new email‐subject API.• File:
application-engine/src/test/groovy/com/netgrif/application/engine/auth/AuthenticationControllerTest.groovy
• Line 122 (current):assert EmailType.REGISTRATION.getSubject().equalsIgnoreCase(message.getSubject())• Action:
– Replace with a call to the new email-subject provider (e.g. the new enum or service)
– Or remove/update the assertion if the subject is now determined differently
♻️ Duplicate comments (2)
docs/javadoc/com/netgrif/application/engine/mail/domain/MailDraft.MailDraftBuilder.html (1)
122-122: Same inconsistency as MailDraft.html.This documentation change also shows package relocation rather than removal, which contradicts the stated goal of extracting email functionality into a separate plugin.
Likely an incorrect or invalid review comment.
docs/javadoc/com/netgrif/application/engine/mail/domain/class-use/MailDraft.MailDraftBuilder.html (1)
6-6: Consistent documentation updates showing relocation.All references to
MailDraft.MailDraftBuilderhave been updated to reflect the package relocation. However, this continues the pattern of showing class relocation rather than removal, which contradicts the PR's stated goal.Also applies to: 25-25, 98-98
Likely an incorrect or invalid review comment.
🧹 Nitpick comments (1)
application-engine/src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy (1)
94-95: Remove unused mail configuration property.This mail configuration property appears to be unused after the removal of mail functionality and should be cleaned up for consistency with the email plugin extraction.
- @Value('${nae.mail.from}') - private String mailFrom
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (22)
application-engine/src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy(1 hunks)application-engine/src/main/java/com/netgrif/application/engine/auth/web/AuthenticationController.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/configuration/MailConfiguration.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/configuration/drools/RuleEngineGlobalsProvider.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/mail/EmailType.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/mail/MailAttemptService.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/mail/MailService.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/mail/domain/MailDraft.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/mail/interfaces/IMailAttemptService.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/mail/interfaces/IMailService.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/mail/throwables/NoEmailTypeDefinedException.java(0 hunks)application-engine/src/main/java/com/netgrif/application/engine/startup/runner/MailRunner.java(0 hunks)application-engine/src/test/groovy/com/netgrif/application/engine/auth/AuthenticationControllerTest.groovy(1 hunks)application-engine/src/test/java/com/netgrif/application/engine/MailSenderServiceTest.java(0 hunks)docs/javadoc/com/netgrif/application/engine/mail/MailService.html(4 hunks)docs/javadoc/com/netgrif/application/engine/mail/domain/MailDraft.MailDraftBuilder.html(1 hunks)docs/javadoc/com/netgrif/application/engine/mail/domain/MailDraft.html(1 hunks)docs/javadoc/com/netgrif/application/engine/mail/domain/class-use/MailDraft.MailDraftBuilder.html(3 hunks)docs/javadoc/com/netgrif/application/engine/mail/domain/class-use/MailDraft.html(6 hunks)docs/javadoc/com/netgrif/application/engine/mail/interfaces/IMailService.html(2 hunks)docs/javadoc/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.html(2 hunks)docs/javadoc/element-list(0 hunks)
💤 Files with no reviewable changes (13)
- application-engine/src/main/java/com/netgrif/application/engine/configuration/drools/RuleEngineGlobalsProvider.java
- application-engine/src/main/java/com/netgrif/application/engine/mail/throwables/NoEmailTypeDefinedException.java
- docs/javadoc/element-list
- application-engine/src/main/java/com/netgrif/application/engine/mail/interfaces/IMailAttemptService.java
- application-engine/src/main/java/com/netgrif/application/engine/mail/EmailType.java
- application-engine/src/main/java/com/netgrif/application/engine/configuration/MailConfiguration.java
- application-engine/src/main/java/com/netgrif/application/engine/mail/MailAttemptService.java
- application-engine/src/main/java/com/netgrif/application/engine/mail/interfaces/IMailService.java
- application-engine/src/main/java/com/netgrif/application/engine/mail/domain/MailDraft.java
- application-engine/src/main/java/com/netgrif/application/engine/startup/runner/MailRunner.java
- application-engine/src/main/java/com/netgrif/application/engine/auth/web/AuthenticationController.java
- application-engine/src/main/java/com/netgrif/application/engine/mail/MailService.java
- application-engine/src/test/java/com/netgrif/application/engine/MailSenderServiceTest.java
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build
🔇 Additional comments (9)
docs/javadoc/com/netgrif/application/engine/mail/domain/MailDraft.html (1)
128-128: Inconsistency: Documentation shows relocation instead of removal.The PR objectives state that email functionality is being extracted into a separate plugin and the AI summary indicates removal of all mail-related functionality. However, this documentation change shows the
MailDraftclass being moved tocom.netgrif.application.engine.objects.mailpackage rather than being removed entirely.#!/bin/bash # Verify if MailDraft class still exists in the new package location fd -t f -e java MailDraft | head -10 ast-grep --pattern 'class MailDraft { $$$ }'Likely an incorrect or invalid review comment.
application-engine/src/test/groovy/com/netgrif/application/engine/auth/AuthenticationControllerTest.groovy (1)
10-10: LGTM: Import statement cleanup.Removed the trailing semicolon from the
IUserimport statement.docs/javadoc/com/netgrif/application/engine/mail/MailService.html (2)
517-523: Anchor ID updated correctly forsendMaildetail.The
<a id="sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">now reflects the new fully qualified type. Ensure all summary links target this anchor.
537-543: Anchor ID updated correctly forbuildEmaildetail.The
<a id="buildEmail(com.netgrif.application.engine.objects.mail.MailDraft)">matches the summary link. Documentation navigation remains consistent.docs/javadoc/com/netgrif/application/engine/mail/interfaces/IMailService.html (1)
233-237: Anchor ID updated correctly forsendMailin interface detail.The
<a id="sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">is accurate. Confirm that the summary table’s link matches this new ID.docs/javadoc/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.html (1)
6900-6900: Javadoc anchor ID correctly updated
The<a id="sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">now matches the new package name and aligns with the method signature link.docs/javadoc/com/netgrif/application/engine/mail/domain/class-use/MailDraft.html (3)
6-6: Update confirmed: Title tag now reflects relocated package path
The<title>element has been correctly updated to usecom.netgrif.application.engine.objects.mail.MailDraft.
25-25: Update confirmed: JavaScript document title updated
Theparent.document.titleassignment now matches the new package path.
98-98: Update confirmed: Header<h2>displays new package path
The main header title attribute and text have been updated tocom.netgrif.application.engine.objects.mail.MailDraft.
| <tr id="i2" class="altColor"> | ||
| <td class="colFirst"><code>void</code></td> | ||
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.mail.domain.MailDraft)">sendMail</a></span>​(<a href="domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | ||
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | ||
| <td class="colLast"> </td> | ||
| </tr> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Broken link: Inconsistent MailDraft reference in sendMail summary.
Similar to above, the summary for sendMail still links to domain/MailDraft.html and mentions the old package. It must be updated to:
- (<a href="domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)
+ (<a href="../objects/mail/MailDraft.html" title="class in com.netgrif.application.engine.objects.mail.MailDraft">MailDraft</a> mailDraft)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <tr id="i2" class="altColor"> | |
| <td class="colFirst"><code>void</code></td> | |
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.mail.domain.MailDraft)">sendMail</a></span>​(<a href="domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | |
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | |
| <td class="colLast"> </td> | |
| </tr> | |
| <tr id="i2" class="altColor"> | |
| <td class="colFirst"><code>void</code></td> | |
| <th class="colSecond" scope="row"><code> | |
| <span class="memberNameLink"> | |
| <a href="#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)"> | |
| sendMail | |
| </a> | |
| </span>​ | |
| ( | |
| <a href="../objects/mail/MailDraft.html" | |
| title="class in com.netgrif.application.engine.objects.mail.MailDraft"> | |
| MailDraft | |
| </a> mailDraft | |
| ) | |
| </code></th> | |
| <td class="colLast"> </td> | |
| </tr> |
🤖 Prompt for AI Agents
In docs/javadoc/com/netgrif/application/engine/mail/MailService.html around
lines 268 to 272, the sendMail method's summary incorrectly links to the old
package path domain/MailDraft.html for the MailDraft parameter. Update the
hyperlink and any package references to point to the correct, current package
location of MailDraft to fix the broken link and ensure consistency.
| <td class="colFirst"><code>protected javax.mail.internet.MimeMessage</code></td> | ||
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#buildEmail(com.netgrif.application.engine.mail.domain.MailDraft)">buildEmail</a></span>​(<a href="domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> draft)</code></th> | ||
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#buildEmail(com.netgrif.application.engine.objects.mail.MailDraft)">buildEmail</a></span>​(<a href="domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> draft)</code></th> | ||
| <td class="colLast"> </td> | ||
| </tr> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Broken link: Inconsistent MailDraft reference in buildEmail summary.
The <a href="domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> still points to the old package. It should reference the relocated class in com.netgrif.application.engine.objects.mail.
Update to something like:
- (<a href="domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> draft)
+ (<a href="../objects/mail/MailDraft.html" title="class in com.netgrif.application.engine.objects.mail.MailDraft">MailDraft</a> draft)🤖 Prompt for AI Agents
In docs/javadoc/com/netgrif/application/engine/mail/MailService.html around
lines 259 to 262, the hyperlink for the MailDraft class in the buildEmail method
points to the old package location. Update the href attribute to reference the
new package path com/netgrif/application/engine/objects/mail/MailDraft.html to
ensure the link correctly points to the relocated class.
| <tr id="i0" class="altColor"> | ||
| <td class="colFirst"><code>void</code></td> | ||
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.mail.domain.MailDraft)">sendMail</a></span>​(<a href="../domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | ||
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | ||
| <td class="colLast"> </td> | ||
| </tr> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Broken link: Inconsistent MailDraft reference in sendMail summary.
The method signature still links to the old domain/MailDraft.html and package path. It must point to the new location:
- (<a href="../domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)
+ (<a href="../../objects/mail/MailDraft.html" title="class in com.netgrif.application.engine.objects.mail.MailDraft">MailDraft</a> mailDraft)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <tr id="i0" class="altColor"> | |
| <td class="colFirst"><code>void</code></td> | |
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.mail.domain.MailDraft)">sendMail</a></span>​(<a href="../domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | |
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | |
| <td class="colLast"> </td> | |
| </tr> | |
| <tr id="i0" class="altColor"> | |
| <td class="colFirst"><code>void</code></td> | |
| <th class="colSecond" scope="row"> | |
| <code> | |
| <span class="memberNameLink"> | |
| <a href="#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)"> | |
| sendMail | |
| </a> | |
| </span>​ | |
| (<a href="../../objects/mail/MailDraft.html" | |
| title="class in com.netgrif.application.engine.objects.mail.MailDraft"> | |
| MailDraft | |
| </a> mailDraft) | |
| </code> | |
| </th> | |
| <td class="colLast"> </td> | |
| </tr> |
🤖 Prompt for AI Agents
In docs/javadoc/com/netgrif/application/engine/mail/interfaces/IMailService.html
around lines 153 to 157, the sendMail method's MailDraft link points to the
outdated domain/MailDraft.html path. Update the href attribute in the anchor tag
to reflect the new package path for MailDraft, ensuring the link correctly
references the current location of the MailDraft class in the documentation.
| <tr id="i341" class="rowColor"> | ||
| <td class="colFirst"><code>void</code></td> | ||
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.mail.domain.MailDraft)">sendMail</a></span>​(<a href="../../../../../mail/domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | ||
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../../../../../mail/domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Broken MailDraft link: update href and title to new package
The <a href> still points to mail/domain/MailDraft.html and uses the old package in its title. It should reference the new objects/mail path and package.
Apply this diff:
-<a href="../../../../../mail/domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a>
+<a href="../../../../../objects/mail/MailDraft.html" title="class in com.netgrif.application.engine.objects.mail.MailDraft">MailDraft</a>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../../../../../mail/domain/MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | |
| <th class="colSecond" scope="row"><code><span class="memberNameLink"><a href="#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../../../../../objects/mail/MailDraft.html" title="class in com.netgrif.application.engine.objects.mail.MailDraft">MailDraft</a> mailDraft)</code></th> |
🤖 Prompt for AI Agents
In
docs/javadoc/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.html
at line 2741, the hyperlink for MailDraft uses an outdated href and title
pointing to mail/domain/MailDraft.html and the old package. Update the href
attribute to point to the new path objects/mail/MailDraft.html and change the
title attribute to reflect the new package
com.netgrif.application.engine.objects.mail.domain to fix the broken link.
| <tr class="altColor"> | ||
| <td class="colFirst"><code>void</code></td> | ||
| <th class="colSecond" scope="row"><span class="typeNameLabel">ActionDelegate.</span><code><span class="memberNameLink"><a href="../../../petrinet/domain/dataset/logic/action/ActionDelegate.html#sendMail(com.netgrif.application.engine.mail.domain.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | ||
| <th class="colSecond" scope="row"><span class="typeNameLabel">ActionDelegate.</span><code><span class="memberNameLink"><a href="../../../petrinet/domain/dataset/logic/action/ActionDelegate.html#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> |
There was a problem hiding this comment.
Fix title attribute on MailDraft link
The anchor’s title still references the old package. Please update it to the new path.
-<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a>
+<a href="../MailDraft.html" title="class in com.netgrif.application.engine.objects.mail">MailDraft</a>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <th class="colSecond" scope="row"><span class="typeNameLabel">ActionDelegate.</span><code><span class="memberNameLink"><a href="../../../petrinet/domain/dataset/logic/action/ActionDelegate.html#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | |
| <th class="colSecond" scope="row"><span class="typeNameLabel">ActionDelegate.</span><code><span class="memberNameLink"><a href="../../../petrinet/domain/dataset/logic/action/ActionDelegate.html#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.objects.mail">MailDraft</a> mailDraft)</code></th> |
🤖 Prompt for AI Agents
In
docs/javadoc/com/netgrif/application/engine/mail/domain/class-use/MailDraft.html
at line 191, the anchor tag's title attribute for the MailDraft link references
an outdated package path. Update the title attribute to reflect the new, correct
package path for MailDraft to ensure accurate documentation links.
| <tr class="rowColor"> | ||
| <td class="colFirst"><code>void</code></td> | ||
| <th class="colSecond" scope="row"><span class="typeNameLabel">MailService.</span><code><span class="memberNameLink"><a href="../../MailService.html#sendMail(com.netgrif.application.engine.mail.domain.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | ||
| <th class="colSecond" scope="row"><span class="typeNameLabel">MailService.</span><code><span class="memberNameLink"><a href="../../MailService.html#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> |
There was a problem hiding this comment.
Fix title attribute on MailDraft link
The anchor’s title still references the old package. Please update it to the new path.
-<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a>
+<a href="../MailDraft.html" title="class in com.netgrif.application.engine.objects.mail">MailDraft</a>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <th class="colSecond" scope="row"><span class="typeNameLabel">MailService.</span><code><span class="memberNameLink"><a href="../../MailService.html#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | |
| <th class="colSecond" scope="row"><span class="typeNameLabel">MailService.</span><code><span class="memberNameLink"><a href="../../MailService.html#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.objects.mail">MailDraft</a> mailDraft)</code></th> |
🤖 Prompt for AI Agents
In
docs/javadoc/com/netgrif/application/engine/mail/domain/class-use/MailDraft.html
at line 147, the anchor tag for MailDraft has a `title` attribute pointing to
the old package path. Update the `title` attribute to reflect the new package
path for MailDraft to ensure accurate documentation references.
| <tr class="altColor"> | ||
| <td class="colFirst"><code>protected javax.mail.internet.MimeMessage</code></td> | ||
| <th class="colSecond" scope="row"><span class="typeNameLabel">MailService.</span><code><span class="memberNameLink"><a href="../../MailService.html#buildEmail(com.netgrif.application.engine.mail.domain.MailDraft)">buildEmail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> draft)</code></th> | ||
| <th class="colSecond" scope="row"><span class="typeNameLabel">MailService.</span><code><span class="memberNameLink"><a href="../../MailService.html#buildEmail(com.netgrif.application.engine.objects.mail.MailDraft)">buildEmail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> draft)</code></th> |
There was a problem hiding this comment.
Fix title attribute on MailDraft link
The anchor’s title still references the old package. Please update it to the new path.
-<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a>
+<a href="../MailDraft.html" title="class in com.netgrif.application.engine.objects.mail">MailDraft</a>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <th class="colSecond" scope="row"><span class="typeNameLabel">MailService.</span><code><span class="memberNameLink"><a href="../../MailService.html#buildEmail(com.netgrif.application.engine.objects.mail.MailDraft)">buildEmail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> draft)</code></th> | |
| <th class="colSecond" scope="row"> | |
| <span class="typeNameLabel">MailService.</span> | |
| <code> | |
| <span class="memberNameLink"> | |
| <a href="../../MailService.html#buildEmail(com.netgrif.application.engine.objects.mail.MailDraft)"> | |
| buildEmail | |
| </a> | |
| </span>​( | |
| <a href="../MailDraft.html" title="class in com.netgrif.application.engine.objects.mail"> | |
| MailDraft | |
| </a> draft) | |
| </code> | |
| </th> |
🤖 Prompt for AI Agents
In
docs/javadoc/com/netgrif/application/engine/mail/domain/class-use/MailDraft.html
at line 142, the anchor tag for MailDraft has a title attribute pointing to the
old package path. Update the title attribute to reflect the new package path for
MailDraft to ensure accurate documentation references.
| <tr class="altColor"> | ||
| <td class="colFirst"><code>void</code></td> | ||
| <th class="colSecond" scope="row"><span class="typeNameLabel">IMailService.</span><code><span class="memberNameLink"><a href="../../interfaces/IMailService.html#sendMail(com.netgrif.application.engine.mail.domain.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> | ||
| <th class="colSecond" scope="row"><span class="typeNameLabel">IMailService.</span><code><span class="memberNameLink"><a href="../../interfaces/IMailService.html#sendMail(com.netgrif.application.engine.objects.mail.MailDraft)">sendMail</a></span>​(<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a> mailDraft)</code></th> |
There was a problem hiding this comment.
Fix title attribute on MailDraft link
The anchor’s title still references the old package. Please update it to the new path.
-<a href="../MailDraft.html" title="class in com.netgrif.application.engine.mail.domain">MailDraft</a>
+<a href="../MailDraft.html" title="class in com.netgrif.application.engine.objects.mail">MailDraft</a>🤖 Prompt for AI Agents
In
docs/javadoc/com/netgrif/application/engine/mail/domain/class-use/MailDraft.html
at line 169, the anchor tag for MailDraft has a title attribute referencing the
old package path. Update the title attribute to reflect the new package path for
MailDraft to ensure accurate documentation links.
| // MessageResource inviteUser(String email) { | ||
| // NewUserRequest newUserRequest = new NewUserRequest() | ||
| // newUserRequest.email = email | ||
| // newUserRequest.groups = new HashSet<>() | ||
| // newUserRequest.processRoles = new HashSet<>() | ||
| // return inviteUser(newUserRequest) | ||
| // } | ||
| // | ||
| // MessageResource inviteUser(NewUserRequest newUserRequest) { | ||
| // IUser user = registrationService.createNewUser(newUserRequest) | ||
| // if (user == null) | ||
| // return MessageResource.successMessage("Done") | ||
| // mailService.sendRegistrationEmail(user) | ||
| // | ||
| // mailAttemptService.mailAttempt(newUserRequest.email) | ||
| // return MessageResource.successMessage("Done") | ||
| // } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove commented-out code that references deleted services.
The commented-out inviteUser methods reference mailService and mailAttemptService that have been removed as part of the email functionality extraction. This dead code should be removed entirely rather than left commented out.
-// MessageResource inviteUser(String email) {
-// NewUserRequest newUserRequest = new NewUserRequest()
-// newUserRequest.email = email
-// newUserRequest.groups = new HashSet<>()
-// newUserRequest.processRoles = new HashSet<>()
-// return inviteUser(newUserRequest)
-// }
-//
-// MessageResource inviteUser(NewUserRequest newUserRequest) {
-// IUser user = registrationService.createNewUser(newUserRequest)
-// if (user == null)
-// return MessageResource.successMessage("Done")
-// mailService.sendRegistrationEmail(user)
-//
-// mailAttemptService.mailAttempt(newUserRequest.email)
-// return MessageResource.successMessage("Done")
-// }If invitation functionality is needed in the future with the email plugin, these methods should be reimplemented to work with the new plugin architecture rather than restored from commented code.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // MessageResource inviteUser(String email) { | |
| // NewUserRequest newUserRequest = new NewUserRequest() | |
| // newUserRequest.email = email | |
| // newUserRequest.groups = new HashSet<>() | |
| // newUserRequest.processRoles = new HashSet<>() | |
| // return inviteUser(newUserRequest) | |
| // } | |
| // | |
| // MessageResource inviteUser(NewUserRequest newUserRequest) { | |
| // IUser user = registrationService.createNewUser(newUserRequest) | |
| // if (user == null) | |
| // return MessageResource.successMessage("Done") | |
| // mailService.sendRegistrationEmail(user) | |
| // | |
| // mailAttemptService.mailAttempt(newUserRequest.email) | |
| // return MessageResource.successMessage("Done") | |
| // } |
🤖 Prompt for AI Agents
In
application-engine/src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy
between lines 1294 and 1310, remove the entire block of commented-out inviteUser
methods that reference mailService and mailAttemptService, as these services
have been removed and the code is now dead. Delete this commented code
completely to clean up the file, and if invitation functionality is needed
later, reimplement it using the new email plugin architecture instead of
restoring this old code.
machacjozef
changed the base branch from
release/7.0.0-rev2
to
release/7.0.0-rev4
Description
Implements NAE-2112
Checklist:
Summary by CodeRabbit
Removed Features
Bug Fixes
Documentation