[NAE-2252] MongoClient ClusterConnectionMode

[Smotanka]

Description

Removed default value for ClusterConnectionMode in MongoDB properties.

Fixes [NAE-2252]

Dependencies

None

Third party dependencies

None

Blocking Pull requests

None

How Has Been This Tested?

User tested

Test Configuration

<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc.>

Name	Tested on
OS	Fedora Workstation 42
Runtime	Java 21.0.8
Dependency Manager	Maven 3.9.9
Framework version	Spring Boot 3.4.4
Run parameters
Other configuration

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes have been checked, personally or remotely, with @...
• I have commented my code, particularly in hard-to-understand areas
• I have resolved all conflicts with the target branch of the PR
• I have updated and synced my code with the target branch
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes:
  • Lint test
  • Unit tests
  • Integration tests
• I have checked my contribution with code analysis tools:
  • SonarCloud
  • Snyk
• I have made corresponding changes to the documentation:
  • Developer documentation
  • User Guides
  • Migration Guides

Summary by CodeRabbit

• Chores
  • Adjusted MongoDB connection mode configuration initialization. Default value handling has been refined to ensure proper configuration behavior.

[coderabbitai]

Walkthrough

The default initialization value for the mode field in DataConfigurationProperties.MongoProperties has been removed. The field previously defaulted to ClusterConnectionMode.SINGLE and now relies on external initialization or null assignment.

Changes

Cohort / File(s)	Summary
MongoDB Configuration application-engine/src/main/java/com/netgrif/application/engine/configuration/properties/DataConfigurationProperties.java	Removed default initialization from ClusterConnectionMode mode field; now declared without default value

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that the mode field is properly initialized elsewhere in the codebase or through dependency injection/configuration
• Check for any code paths that may rely on the previous ClusterConnectionMode.SINGLE default value
• Confirm MongoDB cluster connection handling remains correct without this default

Possibly related PRs

• [NAE-2237] Configurable Connection Properties for MongoDB and Elasticsearch #372: Directly modifies the same ClusterConnectionMode mode field in DataConfigurationProperties.MongoProperties

Suggested labels

Medium

Pre-merge checks

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title mentions MongoClient ClusterConnectionMode but doesn't clearly convey that the change removes a default initialization value from the mode field.	Consider revising the title to be more specific about the change, such as 'Remove default ClusterConnectionMode initialization in MongoDB properties' or 'Reset MongoClient ClusterConnectionMode to null default'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56c6942 and f8edddc.

📒 Files selected for processing (1)

• application-engine/src/main/java/com/netgrif/application/engine/configuration/properties/DataConfigurationProperties.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build

🔇 Additional comments (1)

application-engine/src/main/java/com/netgrif/application/engine/configuration/properties/DataConfigurationProperties.java (1)

277-277: Mode field removal is verified safe; no additional changes needed.

The verification confirms that proper null handling is already in place in MongoClientConfiguration.java (lines 99-100), where the only usage of getMode() checks for null before invoking builder.mode(). When the mode is null, the builder skips the explicit mode configuration, allowing the MongoDB driver to auto-detect the cluster topology—which is the intended behavior of this bugfix.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}