NETOBSERV: 1374 Make enums pascal case

[jpinsonneau]

Description

This PR updates enums to pascal case. It replaces #483 which is outdated.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[jpinsonneau]

@jotak @nathan-weinberg can we please merge this ASAP to avoid yet another rebase ?
This is impacting the API and testing since every enums are updated

Thanks

[nathan-weinberg]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:4476f0c
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-4476f0c
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-4476f0c

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:4476f0c make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-4476f0c

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-4476f0c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[nathan-weinberg]

/label qe-approved

[jpinsonneau]

Rebased without changes

[jotak]

tests are failing, I can take a look if you want

[jotak]

/lgtm

[codecov]

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (b4b578a) 67.11% compared to head (7c0144a) 66.72%.

Files	Patch %	Lines
api/v1beta1/flowcollector_webhook.go	37.03%	52 Missing and 16 partials ⚠️
api/v1beta1/zz_generated.conversion.go	11.29%	55 Missing ⚠️
controllers/ebpf/agent_controller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   67.11%   66.72%   -0.39%     
==========================================
  Files          64       64              
  Lines        7417     7523     +106     
==========================================
+ Hits         4978     5020      +42     
- Misses       2136     2184      +48     
- Partials      303      319      +16     

Flag	Coverage Δ
unittests	66.72% <39.80%> (-0.39%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment