fix(scheduler): iterate over copy when handling time backwards #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time-backwards handling code iterates over entries while calling Update(), which reorders the heap via heap.Fix(). This could cause entries to be visited twice or skipped. Fix by iterating over a copy of the entries slice, ensuring all entries are checked exactly once regardless of heap reordering. Fixes #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix range loop modification bug in time-backwards handling code.
Problem
The for-range loop iterates over
c.entrieswhile callingUpdate(), which reorders elements viaheap.Fix(). This could cause entries to be visited twice or skipped.Solution
Iterate over a copy of the entries slice, ensuring all entries are checked exactly once.
Upstream Reference
Addresses robfig#480 - PR implementing time backwards handling. This fix improves the robustness of time-backwards scenarios.
Test plan
Fixes #40