Apply Nullable/NotNullByDefault annotations #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Nullable/NotNullByDefault annotations give an idea of what to expect from the API. Plus, they provide a better IDE integration. This PR is based on the work done in netty/netty#12878 Modification: Nullable/NotNullByDefault annotations are applied where necessary. Result: The change extends the API with nullability expectations. Plus, it provides a better IDE integration.
normanmaurer
requested changes
Mar 1, 2024
src/main/java/io/netty/incubator/codec/http3/internal/package-info.java
Outdated
Show resolved
Hide resolved
src/main/java/io/netty/incubator/codec/http3/internal/NotNullByDefault.java
Outdated
Show resolved
Hide resolved
normanmaurer
requested changes
Mar 12, 2024
src/main/java/io/netty/incubator/codec/http3/NotNullByDefault.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Norman Maurer <norman_maurer@apple.com>
|
@normanmaurer PTAL |
normanmaurer
approved these changes
Mar 27, 2024
|
@simonatan thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Nullable/NotNullByDefaultannotations give an idea of what to expect from the API. Plus, they provide a better IDE integration. This PR is based on the work done in netty/netty#12878Modification:
Nullable/NotNullByDefaultannotations are applied where necessary.Result:
The change extends the API with nullability expectations. Plus, it provides a better IDE integration.