Refactor set to list in execution context #1197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the return result from a set to a list.
Instead of returning the result for validation/walk, the errors are instead aggregated in a list in the execution context. Clients calling validate from JsonSchema will get a
List
instead of a `Set.This should result in better performance when there are a lot of errors in the run as it's a single arraylist that aggregates results and gets resized, and as hashCode is no longer needed to be called on all the messages as it is no longer a set.
This also changes the version in the pom to be 2.0.0-SNAPSHOT to make it clear that this is a major breaking change.