CI: add NIT tests for nut-scanner/libupsclient #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… comprehensibly for readers of error messages
jimklimov
added
enhancement
nut-scanner
CI
This comment was marked as resolved.
This comment was marked as resolved.
|
AppVeyor: |
…libupsclient.so/dll in path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the test is rudimentary, it allows to check that
nut-scannertool basically works, and the C client library talks to upsd well. In practice during tests in build tree it often depends a lot on libtool wrapper preparing the environment that allows (or not) to find the library at run-time search, so the tests are skipped (not failed) when it says the library could not be found.Also addresses a poorly-understood message on console when "NewNUT" (avahi) discovery fails.
Note: initially hoped this would be a test for sanity-checker from #1811, with dummy-ups configs providing some bogus or duplicate data, but NUT discovery only reports the client/relay connection point, not further details of the already running driver's config or data.
Closes: #1815