Report config parsing errors ("invalid directive") #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimklimov
added
the
service/daemon start/stop
….c: report if config errors were seen and we ignored them (went on) Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
force-pushed
the
report-config-errors
branch
from
c2b5a39 to
c259a0a
Compare
jimklimov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When certain NUT daemons (upsd, upsmon, upssched; also snmp-ups with mib.conf files) initialize and parse their configuration, they used to just report seeing a certain parse error and it was not clear if the problem was considered fatal, or if the service proceeded to start.
With this PR, we report and count all such errors, and if the count was non-zero - issue a message to stress that some config entries were ignored but the program proceeds.
It feels reasonable to not start the mis-configured service as well, so the admins would fix it... But that may be a task for some other PR (e.g. consider an older daemon running against newer-syntax config files).