battery.runtime, status OL/OB and more for Arduino subdriver #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the common status flags as well as time remaining, battery voltage and other variables found in other HID subdrivers. The Arduino library always supported these items, just the NUT subdriver didn't pick them up so things like status were always OB. Signed-off-by: Kelly Byrd <kbyrd@memcpy.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.1.1172-master completed (commit 492754f426 by @jimklimov) |
|
❌ Build nut 2.8.1.1173-master failed (commit 1eaf08b196 by @jimklimov) |
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
Thanks Jim for the NEWS.adoc update! |
|
i didn't ask before, will this make 2.8.2? If the goal is a fast follow bug fix only from 2.8.1, this doesn't fit. But, it would be nice to have a more functional Arduino subdriver get packages up by Debian, Ubuntu, and others. |
|
Yes, it should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the common status flags as well as time remaining, battery voltage and other variables found in other HID subdrivers. The Arduino library always supported these items, just the NUT subdriver didn't pick them up so things like status were always OB.