Update USB product IDs for Belkin/Liebert #2272
Conversation
Follow-up to 3e1b00e which intended to add the ID after NUT v2.7.4 release, but fell prey to copy-paste typo (got 0x0004 instead of intended 0x0000): commit 3e1b00e Author: Charles Lepple <clepple+nut@gmail.com> Date: Sat Jun 3 12:24:15 2017 -0400 usbhid-ups: add Liebert GXT4 USB VID:PID [10AF:0000] Source: http://lists.alioth.debian.org/pipermail/nut-upsuser/2017-June/010682.html Voltage and ConfigVoltage appear to be scaled improperly per the debug output. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…kupstools#2271] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…rs/belkin-hid.c [networkupstools#2271] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
changed the title
|
❌ Build nut 2.8.1.1488-master failed (commit e7ff3bfc80 by @jimklimov) |
|
Would this add support for the Vertiv Liebert PSI5-1100MT120? |
|
Not sure, if directly "yes". If that device has the IDs rectified here, and if it talks the same protocol otherwise - then maybe. You can give a shot to https://github.com/networkupstools/nut/wiki/Building-NUT-for-in%E2%80%90place-upgrades-or-non%E2%80%90disruptive-tests and check directly. There were some recent issue discussions that more and more devices talk USB HID not on "interface 0" but a different one, and a few (sub-)drivers have ways to set the relevant variables when detecting devices, but there is no holistic solution at the moment. Should not be too complex, just needs a bit of time - PRs welcome ;) |
One change is a bug-fix for old contribution; another is at the moment speculative for a newly reported device in #2271 (earlier in #1840).
For new devices with non-zero default interface numbers, best effect can be expected with #2331 merged too (confirmed by testing in tickets above).