nut-scanner: Fix "Old NUT" detection and clarify some log messages
#2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "Old NUT" method available [fallout of networkupstools#2246] If `libupsclient.so` was not loaded, we can not really use this search. Seems like a copy-paste problem mis-adding the NUT Simulation support. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…TH_SNMP_STATIC in nutscan_init() ...and let debug log know we skipped the library search, and why. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… avahi detection in messages/help Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…s not requested "or supported" Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov
added
bug
enhancement
nut-scanner
impacts-release-2.8.2
jimklimov
referenced
this pull request
May 18, 2024
* nut-scanner: detect and configure NUT simlation devices Provide an additional nut-scanner "-n | --nut_simulation_scan" option to detect and configure dummy simulation (.dev & .seq) from the default $sysconfdir. Also advertise NUT Simulation Devices in HCL. This should standardize and streamline the use of nut-scanner as an automatic detection and configuration tool. Closes: #/issues/2242 Signed-off-by: Arnaud Quette <arnaud.quette@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that commit 3eb96fe (PR #2246 for issue #2242) released in NUT v2.8.2 broke detection that
libupsclient.sois not available (not a really practical situation breaking end-user setups, outside of some weird packaging choices on constrained systems, or builds on systems where NUT is not installed into common paths - it did fire up in test cases investigated for another issue #2431).Also this PR takes a moment to clarify what "old nut" is about in
nut-scannercontext (as opposed to "new" avahi-based detection where available) sohelp()and codebase reading is more comprehensible.Finally, this PR changes all flags about detected scanning methods to be zeroed initially, only set to
1(even if always) in thenutscan_init()method, to be consistent.