-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MetricResult.config. #513
Conversation
Co-authored-by: Graham Neubig <neubig@gmail.com>
…Board into refactor-metricresult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick clarification: When writing out the results of an analysis, I believe only MetricResult
is serialized, not Metric
. How would it be possible to get the information about Metric
when loading in the results from a serialized file?
I think
|
OK, sounds good. I'll review this. |
Related to #491
This change removes
MetricResult.config
. This member is not used at this point, and we basically don't need to store the same config in this struct because we can obtain the same information directly fromMetric
.