Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_schema: system_info.{dataset stuff} -> {dataset stuff} #439

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Conversation

lyuyangh
Copy link
Member

blocked by #437
part of #433

This one is a little more involved than the previous ones because dataset is an optional field. Instead of dataset_metadata_id + dataset_split, the following is stored in the database after the change

dataset: {
  dataset_id: string,
  split: string,
  dataset_name: string,
  sub_dataset: string
}

As a result, system_from_dict doesn't need to implement special logic to convert dataset_metadat_id to dataset anymore. Instead, this is handled in create_system(). The POST /systems interface isn't changed so this shouldn't break the client.

@lyuyangh lyuyangh requested a review from neubig as a code owner October 20, 2022 04:29
@lyuyangh lyuyangh marked this pull request as draft October 20, 2022 04:32
@lyuyangh lyuyangh marked this pull request as ready for review October 20, 2022 04:42
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lyuyangh lyuyangh merged commit 61c3d3d into main Oct 24, 2022
@lyuyangh lyuyangh deleted the caching-4 branch October 24, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants