db_schema: system_info.{dataset stuff} -> {dataset stuff} #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by #437
part of #433
This one is a little more involved than the previous ones because
dataset
is an optional field. Instead ofdataset_metadata_id + dataset_split
, the following is stored in the database after the changeAs a result,
system_from_dict
doesn't need to implement special logic to convertdataset_metadat_id
todataset
anymore. Instead, this is handled increate_system()
. The POST /systems interface isn't changed so this shouldn't break the client.