store system_output_metada
in the DB
#493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by #492
part of #433
Stores
system_output_metadata
in the DB because it is required inupdate_overall_statistics()
but we don't have access to the raw system output in this method. Now, the only dependency ofupdate_overall_statistics()
isself
(theSystemModel
instance). This makes it very easy to recompute overall statistics.Note that there is no way of updating
system_output_metadata
for the systems. The loader code is relatively stable but if the loader (implemented in the SDK) is modified, the changes won't be applied to old systems. A better implementation is to store the raw dataset & output files submitted by the user and use that to regeneratesystem_output_metadata
whenupdate_overall_statistics()
is called. That approach requires a bigger change to the current implementation and it also requires all the systems to be re-submitted. That's why I decided to go with the simpler approach for now. I will open an issue for the better approach and we can maybe implement it in the future.Compatibility
explainaboard_client
should still work.