Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store system_output_metada in the DB #493

Merged
merged 1 commit into from
Nov 8, 2022
Merged

store system_output_metada in the DB #493

merged 1 commit into from
Nov 8, 2022

Conversation

lyuyangh
Copy link
Member

@lyuyangh lyuyangh commented Nov 5, 2022

blocked by #492
part of #433
Stores system_output_metadata in the DB because it is required in update_overall_statistics() but we don't have access to the raw system output in this method. Now, the only dependency of update_overall_statistics() is self (the SystemModel instance). This makes it very easy to recompute overall statistics.

Note that there is no way of updating system_output_metadata for the systems. The loader code is relatively stable but if the loader (implemented in the SDK) is modified, the changes won't be applied to old systems. A better implementation is to store the raw dataset & output files submitted by the user and use that to regenerate system_output_metadata when update_overall_statistics() is called. That approach requires a bigger change to the current implementation and it also requires all the systems to be re-submitted. That's why I decided to go with the simpler approach for now. I will open an issue for the better approach and we can maybe implement it in the future.

Compatibility

  • DB migration is required
  • Public interface is not changed so explainaboard_client should still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants