Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BenchmarkDatasetConfig sub_dataset nullable #524

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

qjiang002
Copy link
Collaborator

For datasets without sub_dataset, the sub_dataset property should be nullable, otherwise it will raise error when retrieving datasets for benchmark page.

Copy link
Collaborator

@pfliu-nlp pfliu-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@OscarWang114 OscarWang114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I think there are a couple of fields that should be marked as nullable as well, but we can save those for a future PR. I’ll also work on it.

@qjiang002
Copy link
Collaborator Author

Thanks for fixing this! I think there are a couple of fields that should be marked as nullable as well, but we can save those for a future PR. I’ll also work on it.

I record this in issue #525. Thanks for help.

@qjiang002 qjiang002 merged commit 938372f into main Nov 19, 2022
@qjiang002 qjiang002 deleted the fix-benchmark-dataset-config branch November 19, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants