Resolved type-checking error

neulab · Feb 26, 2024 · 9d29245 · 9d29245
1 parent dff51e4
commit 9d29245
Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/llments/lm/empirical.py b/llments/lm/empirical.py
@@ -34,11 +34,11 @@ def fit(self, target: LanguageModel, task_description: str | None = None):
 
     def calculate_probability(self, x: str) -> float:
         # Implementation logic
-        return 0.0
+        raise NotImplementedError("This is not implemented yet.")
 
-    def sample(self, condition: str | None = None, **kwargs) -> str:
+    def sample(self, condition: str | None, **kwargs) -> str:
         # Implementation logic
-        return ""
+        raise NotImplementedError("This is not implemented yet.")
 
 
 def load_from_text_file(text_file: str):

diff --git a/llments/lm/lm.py b/llments/lm/lm.py
@@ -40,7 +40,7 @@ def calculate_probability(self, output: str) -> float:
         ...
 
     @abc.abstractmethod
-    def sample(self, condition: str | None = None, **kwargs) -> str:
+    def sample(self, condition: str | None, **kwargs) -> str:
         """Sample an output given the language model.
 
         Returns: