Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed continuous integration #8

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Feb 12, 2024

Fixes #7

There were a number of issues in continuous integration, typos, etc.

One of the biggest typos was preventing mypy from being running, and running it fixed a few little errors in the already-implemented functions.

@neubig neubig requested a review from rohanmodi2810 February 12, 2024 19:42
@neubig
Copy link
Contributor Author

neubig commented Feb 12, 2024

Hmm, CI is still not passing, switching this to a draft.

@neubig neubig marked this pull request as draft February 12, 2024 19:47
@neubig neubig marked this pull request as ready for review February 12, 2024 20:05
@neubig
Copy link
Contributor Author

neubig commented Feb 12, 2024

OK, fixed the errors. This is ready for review.

@rohanmodi2810 rohanmodi2810 merged commit 17c7ae0 into main Feb 19, 2024
6 checks passed
@neubig neubig deleted the neubig/fix_continuous_integration branch February 24, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is broken on main
2 participants