Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare package for pypi deployment #9

Merged
merged 2 commits into from
Feb 23, 2024
Merged

prepare package for pypi deployment #9

merged 2 commits into from
Feb 23, 2024

Conversation

wanxinran
Copy link
Collaborator

Changed the pyproject.toml file and put llments inside src folder, please verify this. Thank you!

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! I have requested some changes.

Just to clarify, is there a reason why we need to move the files to the src directory? It seems like we might not need that extra level of hierarchy, which would make things a little easier.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated
Comment on lines 29 to 30
[tool.setuptools.dynamic]
version = {attr = "llments.version.VERSION"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove this, as we will specify the version automatically.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But since we're using hatchling, should we not remove the setuptools parts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not 100% sure if there's another way to do this, but I do know that this makes it possible to dynamically update the version with github version tags. So let's keep it for now.

pyproject.toml Outdated Show resolved Hide resolved
@wanxinran
Copy link
Collaborator Author

Adding a src is not necessary, I was doing it in case we need to add a test directory in the future. I'll undo that change for now.

@wanxinran wanxinran requested a review from neubig February 23, 2024 21:32
pyproject.toml Outdated
Comment on lines 29 to 30
[tool.setuptools.dynamic]
version = {attr = "llments.version.VERSION"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not 100% sure if there's another way to do this, but I do know that this makes it possible to dynamically update the version with github version tags. So let's keep it for now.

@neubig neubig merged commit feba921 into main Feb 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants