Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling AttributeError in smooth_spk function of NWBDataset #16

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Handling AttributeError in smooth_spk function of NWBDataset #16

merged 3 commits into from
Jul 18, 2024

Conversation

arnaghosh
Copy link
Contributor

Should close #15

@arnaghosh
Copy link
Contributor Author

Hi @felixp8,
Could you please review/approve the PR whenever you get time. I am planning on using this library for another project, and it would be nice to use pip install instead of installing from my fork 😅

Thanks in advance. :)

@felixp8
Copy link
Collaborator

felixp8 commented Jul 18, 2024

sorry for the delay! I removed the try-except block since scipy.signal.windows has been the recommended way to access the function for a few years now since version 1.1.0, so I just updated the version requirement also. I will try to make the pip release soon

@felixp8 felixp8 merged commit 4e13434 into neurallatents:main Jul 18, 2024
0 of 9 checks passed
@felixp8
Copy link
Collaborator

felixp8 commented Jul 18, 2024

new version is uploaded to pypi

@arnaghosh
Copy link
Contributor Author

Thanks a lot Felix. No worries about the delay! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixp8 felixp8 felixp8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facing AttributeError when trying to use smooth_spk function
2 participants
@arnaghosh @felixp8