-
Notifications
You must be signed in to change notification settings - Fork 158
Conversation
As it relates to the serialization of act_reordering in [ note: I know this is unrelated to this PR ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have some (manual) tests in place for this as well? It's a subtle modification of the behavior, it would be great to have tested one way or another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a unit test that tests the perplexity for oneshot done with this flag?
Per the main README announcement, SparseML is being deprecated by June 2, 2025. Closing the PR as work has been suspended; thank you for the inputs and support! |
Activation Ordering implementation.
Checked lm_eval value with
actorder=True