Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update cd workflow to install dependencies from requirements.txt #69

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Sep 6, 2023

Changes proposed in this pull request:

  • To ensure extra plugins used by site (e.g., mkdocs-table-reader-plugin) are installed before deploying, install from requirements.txt in cd workflow

Checklist

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit 538168a
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/64f7f12807885a000848ac62
😎 Deploy Preview https://deploy-preview-69--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review September 6, 2023 15:39
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and thanks for fixing main @alyssadai. 🧑‍🍳

A bit concerning still though, that the preview builds succeed but then the actual deployment fails. Could you create an issue where we can discuss a fix.

I think our preview deploys must have picked up the requirements.txt implicitly (uhoh) and thus the previews looked fine, but then the actual deploy failed. Maybe we need to deploy via netlify for staging preview (now) and prod (future) so we are reviewing on the same. Should discuss

@alyssadai
Copy link
Contributor Author

sounds good @surchs, issue is tracked here #71

@alyssadai alyssadai merged commit 3f570f9 into main Sep 6, 2023
@alyssadai alyssadai deleted the alyssadai-patch-1 branch September 6, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants