WIP correct CI errors relating to partial_fit #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the segfault that occurs with honest forest, checkout code here neurodata/treeple#118 and run: |
|
I could not run the test because it always give this import error or ImportError while importing test module '/Users/pssf23/GitHub/scikit-tree/sktree/tests/test_honest_forest.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
scikit-tree/sktree/_lib/sklearn/__check_build/__init__.py:45: in <module>
from ._check_build import check_build # noqa
E ModuleNotFoundError: No module named 'sktree._lib.sklearn.__check_build._check_build' |
|
Oh maybe after building using meson. Run the pip install editable line on the readme? Otw you can't run pytest directly. |
PSSF23
commented
Aug 26, 2023
There was a problem hiding this comment.
Previous commit reduced the only failing CI to macOS pylatest_conda_mkl_no_openmp, but it shows Segmentation Fault again. I really don't understand why all others passed.
This time I removed the parallel preference and see if this has any effects.
Edit: parallel change seems irrelevant. But I can finally recreate the error on my local machine. It probably has something to do with how initial_roots works, so I'll try to optimize the object.
PSSF23
commented
Aug 27, 2023
There was a problem hiding this comment.
@adam2392 I have modified the initial_roots and how it's stored in tree builders. Can you test whether Honest Forest work now on your end? I'm so confused by this bug. It seems that I cannot satisfy all system configurations at once (before it was mac, right now it's windows), but at least there should be improvements.
It seems there is still a segfault in neurodata/treeple#118. If you want to try it out: |
|
I get: |
PSSF23
commented
Aug 28, 2023
There was a problem hiding this comment.
All tests passed for sklearn: https://dev.azure.com/neurodata/neurodata/_build/results?buildId=708&view=results
|
Okay merging in since this seems to fix the CIs. Thanks @PSSF23 ! |
adam2392
added a commit
that referenced
this pull request
Sep 8, 2023
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/main/CONTRIBUTING.md --> #### Reference Issues/PRs <!-- Example: Fixes scikit-learn#1234. See also scikit-learn#3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests --> Fixes #57 #### What does this implement/fix? Explain your changes. #### Any other comments? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. For more information, see our FAQ on this topic: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention. Thanks for contributing! --> --------- Co-authored-by: Adam Li <adam2392@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #57
What does this implement/fix? Explain your changes.
Any other comments?