MAINT Remove NPY deprecated api warnings during meson build (#318)

* Fix meson compile warnings to NPY_1_9 --------- Signed-off-by: Adam Li <adam2392@gmail.com>
neurodata · Aug 20, 2024 · 244c706 · 244c706
1 parent 4062dfd
commit 244c706
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/treeple/_lib/sklearn_fork b/treeple/_lib/sklearn_fork
diff --git a/treeple/meson.build b/treeple/meson.build
@@ -80,7 +80,11 @@ print(incdir)
 endif
 
 inc_np = include_directories(incdir_numpy)
-np_dep = declare_dependency(include_directories: inc_np)
+# Don't use the deprecated NumPy C API. Define this to a fixed version instead of
+# NPY_API_VERSION in order not to break compilation for released SciPy versions
+# when NumPy introduces a new deprecation.
+numpy_no_deprecated_api = ['-DNPY_NO_DEPRECATED_API=NPY_1_9_API_VERSION']
+np_dep = declare_dependency(include_directories: inc_np, compile_args: numpy_no_deprecated_api)
 
 cc = meson.get_compiler('c')
 
@@ -91,7 +95,6 @@ cc = meson.get_compiler('c')
 # py.extension_module('_name',
 #   'source_fname',
 #   numpy_nodepr_api)
-numpy_nodepr_api = '-DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION'
 
 # XXX: ENABLE WHEN DEBUGGING
 boundscheck = 'False'
@@ -106,8 +109,6 @@ scikit_learn_cython_args = [
 ]
 cython_c_args += scikit_learn_cython_args
 
-c_args += numpy_nodepr_api
-
 python_sources = [
   '__init__.py',
   'neighbors.py',