Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Fix failing unit tests #109

Merged
merged 20 commits into from
Aug 16, 2023
Merged

[ENH] Fix failing unit tests #109

merged 20 commits into from
Aug 16, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Aug 14, 2023

Fixes #

Changes proposed in this pull request:

  • Brings in monotonic constraints to decision trees
  • Brings in missing-value support for decision trees and random forests
  • Brings up to speed as of 08/16/23 scikit-learn:main

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 97.71% and project coverage change: -0.30% ⚠️

Comparison is base (52bca43) 86.81% compared to head (a647dbe) 86.52%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   86.81%   86.52%   -0.30%     
==========================================
  Files          24       26       +2     
  Lines        1919     2063     +144     
==========================================
+ Hits         1666     1785     +119     
- Misses        253      278      +25     
Files Changed Coverage Δ
sktree/ensemble/_supervised_forest.py 100.00% <ø> (ø)
sktree/ensemble/_honest_forest.py 91.46% <61.53%> (-5.68%) ⬇️
sktree/__init__.py 80.00% <100.00%> (+0.83%) ⬆️
sktree/tests/test_honest_forest.py 100.00% <100.00%> (ø)
sktree/tree/_classes.py 74.93% <100.00%> (-1.45%) ⬇️
sktree/tree/_honest_tree.py 100.00% <100.00%> (ø)
sktree/tree/tests/test_all_trees.py 100.00% <100.00%> (ø)
sktree/tree/tests/test_honest_tree.py 100.00% <100.00%> (ø)
sktree/tree/tests/test_tree.py 99.48% <100.00%> (-0.16%) ⬇️
sktree/tree/tests/test_unsupervised_tree.py 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 3b124e3 into main Aug 16, 2023
24 of 25 checks passed
@adam2392 adam2392 deleted the fix branch August 16, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant