Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add conditional resampling using nearest-neighbor algorithm #170

Merged
merged 15 commits into from
Nov 15, 2023

Conversation

adam2392
Copy link
Collaborator

Towards: #152

and #110

Changes proposed in this pull request:

  • Adds an API for leveraging NearestNeighbor API of scikit-learn to perform conditional NN resampling (with and without replacement)

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (030a064) 89.59% compared to head (25d7240) 89.93%.
Report is 1 commits behind head on main.

❗ Current head 25d7240 differs from pull request most recent head 2d9b718. Consider uploading reports for the commit 2d9b718 to get more accurate results

Files Patch % Lines
sktree/experimental/monte_carlo.py 95.52% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   89.59%   89.93%   +0.34%     
==========================================
  Files          46       48       +2     
  Lines        3710     3866     +156     
==========================================
+ Hits         3324     3477     +153     
- Misses        386      389       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam2392
Copy link
Collaborator Author

This may or may not be used for the cancer project, but is definitely required for the (C)MI project

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 620950d into neurodata:main Nov 15, 2023
24 of 25 checks passed
@adam2392 adam2392 deleted the montecarlo branch November 15, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant