Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Update documentation #299

Merged
merged 6 commits into from
Jul 19, 2024
Merged

DOC Update documentation #299

merged 6 commits into from
Jul 19, 2024

Conversation

adam2392
Copy link
Collaborator

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Updates developer documentation, so the information is consolidated and anyone can do a release, or build from source

Any other comments?

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SUKI-O this is where it would be great to hear your thoughts on this workflow.

Is it confusing? Could it be improved?

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.53%. Comparing base (fae7e5c) to head (be7681a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files          24       24           
  Lines        2250     2250           
  Branches      413      413           
=======================================
  Hits         1767     1767           
  Misses        352      352           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Member

@SUKI-O SUKI-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for updating this. I also added a few line in the other PR under rename. would you plz review that one?

DEVELOPING.md Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 699bcbd into neurodata:main Jul 19, 2024
5 checks passed
@adam2392 adam2392 deleted the docupdate branch July 19, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants