modified: sktree/tree/manifold/_morf_splitter.pyx #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added one new attributes named n_features_1, and change sample_proj_mat code. my problem is, If the change below is doable, how to define n_features_1 in classes, can I set it as an input? |
adam2392
reviewed
Jun 22, 2023
| for proj_i in range(0, max_features): | ||
|
|
||
| ##### suposse randomly select one feature set to find a best split | ||
| cdef np.ndarray[int, ndim=1] choices = np.array([0, n_features_1]) |
There was a problem hiding this comment.
This doesn't work inside nogil. To instantiate an array requires the GIL.
I thought what you are trying to do is pass in n_features_1 = the # of features in dataset 1. Then X[:, :n_features_1] is dataset 1 and X[:, n_features_1:] is dataset 2?
There was a problem hiding this comment.
yes! Sorry, I didn't check the git timely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the morf_splitter for multi-view of MORF.