Add @with_logging decorator to automate logging setup/teardown#646
Open
Pradyumn-cloud wants to merge 3 commits intoneuroinformatics-unit:mainfrom
Open
Add @with_logging decorator to automate logging setup/teardown#646Pradyumn-cloud wants to merge 3 commits intoneuroinformatics-unit:mainfrom
Pradyumn-cloud wants to merge 3 commits intoneuroinformatics-unit:mainfrom
Conversation
… This solves the issue where manual logging setup/teardown was error-prone and easy to forget for new public functions.
Member
|
Hi @Pradyumn-cloud thanks for this! This looks really cool, you've covered all of the possible cases nicely. It will take me until next week to review in full, will get back to you ASAP! Cheers |
Member
|
Hi @Pradyumn-cloud apologies for the delay with this, will definitely review by the end of this week |
Member
|
Hi @Pradyumn-cloud sorry for the delay here, I had a look at I think the code looks like it should work. Can you please start adding this decorator to functions and we can see what happens with the tests. Thanks! |
Author
|
ok |
Author
|
I think there are two logging... I forgot to remove the existing manual. Let me do changes to fix it. |
remove earlier logging method, remove logging from private methods and Added init_log=False to internal function calls to prevent nested logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX ISSUE - #548
This solves the issue where manual logging setup/teardown was error-prone and easy to forget for new public functions.
Description
What is this PR
Checklist: