Fix: Update keyboard shortcut tooltips for macOS compatibility (Fixes #617)#681
Fix: Update keyboard shortcut tooltips for macOS compatibility (Fixes #617)#681AdityaGupta716 wants to merge 22 commits intoneuroinformatics-unit:mainfrom
Conversation
…euroinformatics-unit#617) Updated keyboard shortcut tooltips in tooltips.py to emphasize CTRL+C (with SHIFT) instead of CTRL+Q for copying filepath to clipboard. CTRL+Q quits the application on macOS, so CTRL+C is the more appropriate shortcut for users on that platform.
for more information, see https://pre-commit.ci
Add module docstring for custom exceptions.
for more information, see https://pre-commit.ci
|
Hi @AdityaGupta716 thanks for this. I think we will need to choose another key here, rather than CTRL+C with shift. CTRL+Q will copy the file path from the folder icon, but CTRL+C with shift will not do this, as it only copies what is visible on the screen. Maybe CTRL+W, CTRL+Q works well for this in all cases except macOS. |
|
Ok i'll update the tooltip to suggest ctrl w instead so we avoid mac ctrl+q issue but still have a working shortcut |
|
Thanks @AdityaGupta716, we will need to change the key combination in the code as well. Ideally, we will find all instances of "CTRL+Q" / "ctrl+q", see where they are used, and manually test with CTR+W after updating them to ensure everything is working. |
Updated notification message for copy actions.
|
@JoeZiminski i have changed the copy filepath from ctrl q to ctrl w and also changed the relevant codebase. i wasnt able to run the full TUI locally because some rclone related error but i did the changes u wanted me to do |
2 participants
What is this PR
Why is this PR needed?
Issue #617 reported that the CTRL+Q keyboard shortcut tooltip is problematic on macOS because CTRL+Q quits the application on that platform. This PR updates the tooltip to emphasize CTRL+C (with SHIFT) instead, which is the correct way to copy the highlighted file path to the clipboard.
What does this PR do?
Updates keyboard shortcut tooltips in
datashuttle/tui/tooltips.pyto clarify that users should use CTRL+C with SHIFT to copy the filepath to the clipboard. This avoids the accidental application quit on macOS when users press CTRL+Q.