Skip to content

Add type hints to test_links.py (#532) #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdityaGupta716 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add type hints to test_links.py (#532) #682

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe80b84
Fix: Update keyboard shortcut tooltips for macOS compatibility (Fixes…
AdityaGupta716 Feb 7, 2026
034b2ec
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 7, 2026
e6f651a
Add docstring to custom_exceptions.py
AdityaGupta716 Feb 7, 2026
d77ab4f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 7, 2026
757b02a
Add type hints to test_links.py (#532)
AdityaGupta716 Feb 7, 2026
8302dfa
Update tooltips.py
AdityaGupta716 Feb 16, 2026
bbb7633
Update custom_exceptions.py
AdityaGupta716 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/tests_unit/test_links.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
from datashuttle.configs import links


def test_links():
def test_links() -> None:
"""Test canonical links are working. Unfortunately Zulip links cannot
be validated.
"""
assert validators.url(links.get_docs_link())
assert validators.url(links.get_github_link())
assert validators.url(links.get_link_github_issues())
# assert validators.url(links.get_link_zulip()) Zulip links fail even when valid...
# assert validators.url(links.get_link_zulip()) Zulip links fail even when valid