Add unit tests for fit_ellipse_to_points function Resolves #36 Adds…#61
Open
AdityaGupta716 wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Open
Add unit tests for fit_ellipse_to_points function Resolves #36 Adds…#61AdityaGupta716 wants to merge 1 commit intoneuroinformatics-unit:mainfrom
AdityaGupta716 wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Conversation
…matics-unit#36 Adds comprehensive tests to verify correct ellipse center estimation. This file contains unit tests for the fit_ellipse_to_points function, verifying its behavior with various point patterns, including circular and elliptical arrangements, as well as edge cases with insufficient points and NaN values.
Member
|
Hi @AdityaGupta716, as said in the issue #36, this PR is a duplicate of #60 and you might want to describe how it covers the same edge cases, and/or join efforts with @AlgoFoe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive unit tests for the
fit_ellipse_to_pointsfunction in the derotation module.What is this PR?
Testing
The tests verify:
All tests use synthetic geometric patterns with known centers to verify accuracy within specified tolerances.
Related Issues
Resolves #36