Update bispectra feature #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsbinns
commented
Oct 2, 2024
| # PyBispectra's compute_fft uses PQDM to parallelize the calculation per channel | ||
| # Is this necessary? Maybe the overhead of parallelization is not worth it | ||
| # considering that we incur in it once per batch of data | ||
| fft_coeffs, freqs = compute_fft( |
There was a problem hiding this comment.
I switched away from pqdm, so this comment is no longer true.
tsbinns
commented
Oct 2, 2024
| @@ -127,12 +124,11 @@ def calc_feature(self, data: np.ndarray) -> dict: | |||
| f1s=tuple(self.settings.f1s), # type: ignore | |||
| f2s=tuple(self.settings.f2s), # type: ignore | |||
| ) | |||
| waveshape = waveshape.results.get_results(copy=False) # can overwrite obj with array | |||
There was a problem hiding this comment.
This is a less hacky way of extracting the bispectral info while avoiding a copy, without relying on private attrs.
|
Many thanks for the contribution @tsbinns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces some jankiness with the bispectra feature now that PyBispectra v1.2 is available (was already pinned in #355).