Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make notebooks work with bokeh>=3 and remove bokeh<3 pin #3061

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Make notebooks work with bokeh>=3 and remove bokeh<3 pin #3061

merged 4 commits into from
Oct 2, 2024

Conversation

kbvw
Copy link
Contributor

@kbvw kbvw commented Aug 28, 2024

No description provided.

@kbvw kbvw force-pushed the bokeh3 branch 2 times, most recently from 15be227 to 5d67f94 Compare August 28, 2024 06:39
1uc
1uc previously approved these changes Aug 28, 2024
View reviewed changes
@azure-pipelines Azure Pipelines
Copy link

✔️ 038ac61 -> Azure artifacts URL

matz-e
matz-e previously approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple solution!

@bbpbuildbot

This comment has been minimized.

Sign in to view
alkino
alkino previously approved these changes Aug 28, 2024
View reviewed changes
@kbvw kbvw force-pushed the bokeh3 branch 2 times, most recently from f084e3f to 827637e Compare August 29, 2024 08:00
@kbvw
Copy link
Contributor Author

kbvw commented Aug 29, 2024 •
edited
Loading

For some reason this seems to work locally but it fails in the CI. I'm looking into it.

EDIT: The error was actually from the other notebook, and with jupyter nbconvert --debug the output was so huge that I didn't spot that. It works fine.

@azure-pipelines Azure Pipelines
Copy link

✔️ 827637e -> Azure artifacts URL

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.89%. Comparing base (a2b8b35) to head (2d8ba03).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
share/lib/python/neuron/__init__.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3061   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files         572      572           
  Lines      106659   106664    +5     
=======================================
+ Hits        71351    71356    +5     
  Misses      35308    35308

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@kbvw kbvw force-pushed the bokeh3 branch 4 times, most recently from c348153 to e7b80ee Compare August 29, 2024 14:55
@kbvw
Copy link
Contributor Author

kbvw commented Aug 29, 2024

Also unpinned numpy<2 in docs_requirements.txt as this was the only thing left blocking that.

@azure-pipelines Azure Pipelines
Copy link

✔️ b548c96 -> Azure artifacts URL

@kbvw kbvw mentioned this pull request Aug 29, 2024
Open
@azure-pipelines Azure Pipelines
Copy link

✔️ e7b80ee -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@ramcdougal ramcdougal self-requested a review August 29, 2024 15:54
ramcdougal
ramcdougal previously requested changes Aug 29, 2024
View reviewed changes
docs/tutorials/scripting-neuron-basics.ipynb Outdated Show resolved Hide resolved
@kbvw kbvw force-pushed the bokeh3 branch 2 times, most recently from 8bfc8bb to 09a154a Compare August 29, 2024 16:36
@azure-pipelines Azure Pipelines
Copy link

✔️ 09a154a -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ e89d97b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@1uc 1uc dismissed stale reviews from alkino, matz-e, and themself August 30, 2024 06:32

outdated

@1uc 1uc closed this Aug 30, 2024
@1uc 1uc reopened this Aug 30, 2024
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ e89d97b -> Azure artifacts URL

@1uc 1uc closed this Sep 2, 2024
@1uc 1uc reopened this Sep 2, 2024
@azure-pipelines Azure Pipelines
Copy link

✔️ e89d97b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@kbvw kbvw requested a review from ramcdougal September 9, 2024 09:29
@azure-pipelines Azure Pipelines
Copy link

✔️ a4e1f33 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@azure-pipelines Azure Pipelines
Copy link

✔️ 2d8ba03 -> Azure artifacts URL

@pramodk pramodk dismissed ramcdougal’s stale review October 2, 2024 16:25

Already addressed

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #234726 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk pramodk merged commit 5b49b24 into master Oct 2, 2024
37 checks passed
@pramodk pramodk deleted the bokeh3 branch October 2, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz-e matz-e matz-e approved these changes

@alkino alkino alkino left review comments

@1uc 1uc 1uc left review comments

@ramcdougal ramcdougal Awaiting requested review from ramcdougal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kbvw @bbpbuildbot @alkino @matz-e @ramcdougal @1uc @pramodk