-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move nmodl directory to nocmodl #3110
Conversation
✔️ bd6fb53 -> Azure artifacts URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The road is clear to add the new NMODL. There may be a few remaining changes of the 5 letter NMODL to NOCMODL such as
cmake/BuildOptionDefaults.cmake:set(NRN_NMODL_CXX_FLAGS_DEFAULT "-O0")
but until the new NMODL comes in it won't be clear whether a distinction will need to be made between NOCMODL and NMODL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3110 +/- ##
=======================================
Coverage 66.89% 66.89%
=======================================
Files 572 572
Lines 106664 106664
=======================================
+ Hits 71348 71358 +10
+ Misses 35316 35306 -10 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
Quality Gate passedIssues Measures |
✔️ 99168c4 -> Azure artifacts URL |
✔️ d7dc653 -> Azure artifacts URL |
This way nmodl (the real one) can join soon!