Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nmodl directory to nocmodl #3110

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Move nmodl directory to nocmodl #3110

merged 3 commits into from
Oct 3, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Oct 3, 2024

This way nmodl (the real one) can join soon!

@pramodk pramodk requested a review from nrnhines October 3, 2024 11:55
Copy link

✔️ bd6fb53 -> Azure artifacts URL

Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The road is clear to add the new NMODL. There may be a few remaining changes of the 5 letter NMODL to NOCMODL such as

cmake/BuildOptionDefaults.cmake:set(NRN_NMODL_CXX_FLAGS_DEFAULT "-O0")

but until the new NMODL comes in it won't be clear whether a distinction will need to be made between NOCMODL and NMODL

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.89%. Comparing base (5b49b24) to head (99168c4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3110   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files         572      572           
  Lines      106664   106664           
=======================================
+ Hits        71348    71358   +10     
+ Misses      35316    35306   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Oct 3, 2024

Copy link

✔️ 99168c4 -> Azure artifacts URL

@pramodk pramodk enabled auto-merge (squash) October 3, 2024 15:17
Copy link

✔️ d7dc653 -> Azure artifacts URL

@pramodk pramodk merged commit 51bb95d into master Oct 3, 2024
35 checks passed
@pramodk pramodk deleted the cornu/nmodl_to_nocmodl branch October 3, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants