Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api/updater.md with a note about required nativeAllowList strings #331

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Update api/updater.md with a note about required nativeAllowList strings #331

merged 2 commits into from
Aug 2, 2024

Conversation

CosmoMyzrailGorynych
Copy link
Contributor

updater.install fails with NE_UP_UPDINER if filesystem API is not allowed. This PR adds a small note that you need to allow filesystem and updater in one's neutralino.config.json.

Copy link
Member

@shalithasuranga shalithasuranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @CosmoMyzrailGorynych for sending this PR. I've done some changes in c1bea48

Could you please check whether the new note's instructions work for you? Thanks 🎉

@shalithasuranga shalithasuranga merged commit def7c88 into neutralinojs:main Aug 2, 2024
@CosmoMyzrailGorynych
Copy link
Contributor Author

Thanks for tweaking this PR; the issue with docs was reported by a user on Discord server, I will ask them whether filesystem.writeBinaryFile is enough.

@shalithasuranga could you also review neutralinojs/neutralino.js#117 and neutralinojs/neutralinojs-cli#268 ?

@shalithasuranga
Copy link
Member

Welcome and thanks @CosmoMyzrailGorynych Sure, I'll check and merge those PRs as well soon 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants