Feature/revive compute #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaitor
requested changes
Nov 11, 2022
| @@ -26,7 +26,7 @@ MINIKUBE_RECREATE=${MINIKUBE_RECREATE:-true} | |||
| START_MINIKUBE=${START_MINIKUBE:-true} | |||
| CONFIGURE_K8S_COMPUTE=${CONFIGURE_K8S_COMPUTE:-true} | |||
| COMPUTE_NAMESPACE=${COMPUTE_NAMESPACE:-nvm-disc} | |||
|
|
|||
| KEEPER_ARTIFACTS_FOLDER="${HOME}/nevermined-contracts/artifacts" | |||
There was a problem hiding this comment.
This variable is already defined in the start_nevermined.sh file:
export KEEPER_ARTIFACTS_FOLDER="${NEVERMINED_HOME}/nevermined-contracts/artifacts"
So I don't think needs to be re-defined here
| @@ -259,11 +259,14 @@ configure_nevermined_compute() { | |||
| $K create namespace $COMPUTE_NAMESPACE | |||
| fi | |||
|
|
|||
| #mount local directory to minikube vm | |||
| #echo -e "${COLOR_B}Creating configmap with artifacts from folder ${KEEPER_ARTIFACTS_FOLDER} ...${COLOR_RESET}" | ||
| #$K create -n $COMPUTE_NAMESPACE configmap artifacts --from-file=${KEEPER_ARTIFACTS_FOLDER} | ||
|
|
||
| # Install argo artifacts | ||
| helm install -n $COMPUTE_NAMESPACE argo-artifacts stable/minio --set fullnameOverride=argo-artifacts --set resources.requests.memory=1Gi | ||
| helm install -n $COMPUTE_NAMESPACE argo-artifacts bitnami/minio --version 11.10.13 --set fullnameOverride=argo-artifacts --set resources.requests.memory=1Gi |
There was a problem hiding this comment.
minio version should be defined in an environment variable like MINIKUBE_VERSION and not hardcoded here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a description of your changes here.
Is this PR related with an open issue?
Related to Issue #
Types of changes
Checklist: