Map cloned/inserted statements to a corresponding original bytecode statement #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sifislag
reviewed
Nov 20, 2023
clientlib/vulnerability_macros.dl
Outdated
There was a problem hiding this comment.
Is this new output needed?
There was a problem hiding this comment.
When examining a vulnerability in the TAC level we often have to go up from the processed vulnerability statement to the TAC statement. Not a "must-have" change, more of a "nice-to-have" one.
logic/decompiler_output.dl
Outdated
| LocalBlockEdge(irblock, irblock_next), | ||
| Block_IRBlock(block_next, _, irblock_next), | ||
| stmt_nexthead = as(block_next, Statement). | ||
| insertor.InsertedOpNewStatement(ogStmt, _, stmt). |
There was a problem hiding this comment.
Doesn't this case also need to use PreTransStatement_OriginalStatement?
ibollanos
force-pushed
the
map_cloned_stmts
branch
from
94f8888
to
1cb95ae
Compare
sifislag
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.