Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute the actual last continuation in the incomplete global pre-analysis #153

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

sifislag
Copy link
Collaborator

@sifislag sifislag commented Sep 18, 2024

And use it on the main global analysis.

Only affects viair contracts, where the order the continuations are pushed to the stack is not kept after each call return.

Added the motivating example as a test.

Results

viair-dec23

2933 contracts decompiled/analyzed by sep24-ir-decompfix (0 exclusively)                                                                     
2937 contracts decompiled/analyzed by sep24-ir-incomp2 (4 exclusively)

ANALYTIC: decomp_time
sep24-ir-decompfix (common): 29362.651762247086
sep24-ir-incomp2 (common): 29421.400084733963 (+0.2001%)

ANALYTIC: Analytics_JumpToMany
sep24-ir-decompfix (common): 4315
sep24-ir-incomp2 (common): 4315

ANALYTIC: Analytics_DeadBlocks
sep24-ir-decompfix (common): 504 (+0.8%)
sep24-ir-incomp2 (common): 500

ANALYTIC: Analytics_PolymorphicTargetSameCtx
sep24-ir-decompfix (common): 92 (+15%)
sep24-ir-incomp2 (common): 80

ANALYTIC: Analytics_Contexts
sep24-ir-decompfix (common): 4340452 (+8.99%)
sep24-ir-incomp2 (common): 3982420

metadata-dataset1

1996 contracts decompiled/analyzed by sep24-meta-decompfix (0 exclusively)
1996 contracts decompiled/analyzed by sep24-meta-incomp2 (0 exclusively)

ANALYTIC: decomp_time
sep24-meta-decompfix (common): 12457.97710776329
sep24-meta-incomp2 (common): 12532.801411390305 (+0.6006%)

ANALYTIC: Analytics_JumpToMany
sep24-meta-decompfix (common): 113
sep24-meta-incomp2 (common): 113

ANALYTIC: Analytics_Contexts
sep24-meta-decompfix (common): 1231829
sep24-meta-incomp2 (common): 1231859 (+0.002435%)

Copy link

Test Results (Souffle 2.3)

57 tests  +1   57 ✅ +1   39m 15s ⏱️ +55s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit d785449. ± Comparison against base commit 37ba5bf.

Copy link

Test Results (Souffle 2.4)

57 tests  +1   57 ✅ +1   39m 35s ⏱️ -17s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit d785449. ± Comparison against base commit 37ba5bf.

@sifislag sifislag merged commit bb8f65c into master Sep 18, 2024
5 checks passed
@sifislag sifislag deleted the incomplete_global_last_continuation branch September 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant