feat(synth): Update default isBlocking behavior

internal/synthetics/command_batch_run.go

@@ -102,6 +102,19 @@
 		return config, err
 	}
 
+	// Detect YAML file tests whose 'isBlocking' key is absent
+	indexes, err := getTestsMissingIsBlockingInConfig(content)
+	if err != nil {
+		return config, err
+	}
+
+	// YAML file's tests with 'isBlocking' absent default to 'isBlocking: true' to match Synthetics API's default
+	if len(indexes) > 0 {
+		for _, v := range indexes {
+			config.Tests[v].Config.IsBlocking = true
+		}
+	}
+
 	utils.LogIfFatal(err)
 	return config, nil
 }
@@ -112,6 +125,9 @@
 	var tests []synthetics.SyntheticsAutomatedTestMonitorInput
 	for _, id := range guids {
 		tests = append(tests, synthetics.SyntheticsAutomatedTestMonitorInput{
+			Config: synthetics.SyntheticsAutomatedTestMonitorConfigInput{
+				IsBlocking: true, // Matches default value in Synthetics API
+			},
 			MonitorGUID: synthetics.EntityGUID(id),
 		})
 	}
@@ -220,3 +236,33 @@
 
 	return summaryMessage, tableData
 }
+
+// getTestsMissingIsBlockingInConfig parses monitors tests configurations YAML in order to detect
+// if any of them is missing the 'isBlocking' config key
+func getTestsMissingIsBlockingInConfig(data []byte) ([]int, error) {
+	type Data struct {
+		Tests []struct {
+			monitorGUID string `yaml:"monitorGuid"`
+			Config      struct {
+				IsBlocking string `yaml:"isBlocking"`
+			}
+		} `yaml:"tests"`
+	}
+
+	var d Data
+
+	err := yaml.Unmarshal(data, &d)
+	if err != nil {
+		return nil, err
+	}
+
+	c := make([]int, 0)
+
+	for i := range d.Tests {
+		if d.Tests[i].Config.IsBlocking == "" {
+			c = append(c, i)
+		}
+	}
+
+	return c, nil
+}

internal/synthetics/command_batch_run_test.go

@@ -0,0 +1,143 @@
+//go:build unit
+// +build unit
+
+package synthetics
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+
+	"github.com/newrelic/newrelic-client-go/v2/pkg/synthetics"
+)
+
+func TestCreateConfigurationUsingGUIDs_ReturnsIsBlockingSetToTrueForAllMonitors(t *testing.T) {
+	guids := []string{
+		"abc",
+		"xyz",
+	}
+
+	config := createConfigurationUsingGUIDs(guids)
+
+	for i, guid := range guids {
+		assert.Equal(t, config.Tests[i].MonitorGUID, synthetics.EntityGUID(guid))
+		assert.Equal(t, config.Tests[i].Config.IsBlocking, true)
+	}
+}
+
+func TestGetTestsMissingIsBlockingInConfig_ShouldReturnFirstTestOnly(t *testing.T) {
+	var data = `
+config:
+  batchName: test
+  branch: dev
+  commit: abc123
+  deepLink: https://example.com
+  platform: CLI
+  repository: repo
+tests:
+  - monitorGuid: NDE3N
+    config:
+  - monitorGuid: ZDFOQ
+    config:
+      isBlocking: false
+  - monitorGuid: USHxN
+    config:
+      isBlocking: true
+      overrides:
+        location: east-1
+        domain:
+          - domain: http://example.org
+            override: https://example.com
+`
+	indexes, err := getTestsMissingIsBlockingInConfig([]byte(data))
+
+	assert.Equal(t, nil, err)
+	assert.Equal(t, 1, len(indexes))
+	assert.Equal(t, 0, indexes[0])
+}
+
+func TestGetTestsMissingIsBlockingInConfig_ShouldReturnLastTestOnly(t *testing.T) {
+	var data = `
+config:
+  batchName: test
+  branch: dev
+  commit: abc123
+  deepLink: https://example.com
+  platform: CLI
+  repository: repo
+tests:
+  - monitorGuid: NDE3N
+    config:
+      isBlocking: true
+  - monitorGuid: ZDFOQ
+    config:
+      isBlocking: false
+  - monitorGuid: USHxN
+    config:
+      overrides:
+        location: east-1
+        domain:
+          - domain: http://example.org
+            override: https://example.com
+`
+	indexes, err := getTestsMissingIsBlockingInConfig([]byte(data))
+
+	assert.Equal(t, nil, err)
+	assert.Equal(t, 1, len(indexes))
+	assert.Equal(t, 2, indexes[0])
+}
+
+func TestGetTestsMissingIsBlockingInConfig_ShouldReturnThreeTests(t *testing.T) {
+	var data = `
+config:
+  batchName: test
+  branch: dev
+  commit: abc123
+tests:
+  - monitorGuid: NDE3N
+    config:
+  - monitorGuid: ZDFOQ
+    config:
+  - monitorGuid: USHxN
+    config:
+      overrides:
+        location: east-1
+        domain:
+          - domain: http://example.com
+            override: https://example.com
+`
+	indexes, err := getTestsMissingIsBlockingInConfig([]byte(data))
+
+	assert.Equal(t, nil, err)
+	assert.Equal(t, 3, len(indexes))
+}
+
+func TestGetTestsMissingIsBlockingInConfig_ShouldReturnNone(t *testing.T) {
+	var data = `
+config:
+  batchName: test
+  branch: dev
+  commit: abc123
+tests:
+  - monitorGuid: NDE3N
+    config:
+      isBlocking: false
+      overrides:
+        location: east-1
+  - monitorGuid: ZDFOQ
+    config:
+      isBlocking: false
+      overrides:
+        location: east-1
+        domain:
+          - domain: http://example.com
+            override: https://example.com
+  - monitorGuid: USHxN
+    config:
+      isBlocking: true
+`
+	indexes, err := getTestsMissingIsBlockingInConfig([]byte(data))
+
+	assert.Equal(t, nil, err)
+	assert.Equal(t, 0, len(indexes))
+}