Skip to content

Commit

Permalink
Remove supportability metric reporter
Browse files Browse the repository at this point in the history
  • Loading branch information
tippmar-nr committed Oct 11, 2023
1 parent 02d278d commit 20a3e1d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 37 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ public CanWrapResponse CanWrap(InstrumentedMethodInfo methodInfo)

public AfterWrappedMethodDelegate BeforeWrappedMethod(InstrumentedMethodCall instrumentedMethodCall, IAgent agent, ITransaction transaction)
{
// report kafka client version in a supportability metric, one time only
KafkaSupportabilityMetricReporter.ReportKafkaSupportabilityMetric(agent, instrumentedMethodCall.MethodCall.Method.Type);

transaction = agent.CreateTransaction(
destinationType: MessageBrokerDestinationType.Topic,
brokerVendorName: BrokerVendorName,
Expand All @@ -45,9 +42,10 @@ public AfterWrappedMethodDelegate BeforeWrappedMethod(InstrumentedMethodCall ins
{
if (resultAsObject == null) // null is a valid return value, so we have to handle it.
{
// TODO: Uncommenting the following lines results in *no* transactions for kafka consume. No idea why.
//segment.End();
//transaction.Ignore(); // nothing to see here, move along
segment.End();
transaction.Ignore();
transaction.End();

return;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ public CanWrapResponse CanWrap(InstrumentedMethodInfo methodInfo)

public AfterWrappedMethodDelegate BeforeWrappedMethod(InstrumentedMethodCall instrumentedMethodCall, IAgent agent, ITransaction transaction)
{
// report kafka client version in a supportability metric, one time only
KafkaSupportabilityMetricReporter.ReportKafkaSupportabilityMetric(agent, instrumentedMethodCall.MethodCall.Method.Type);

var topicPartition = instrumentedMethodCall.MethodCall.MethodArguments.ExtractNotNullAs<TopicPartition>(0);
var messageMetadata = instrumentedMethodCall.MethodCall.MethodArguments.ExtractNotNullAs<MessageMetadata>(1);

Expand Down

This file was deleted.

0 comments on commit 20a3e1d

Please sign in to comment.