Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adjust metric harvest cycle and introduce a delay for linux smoke tests #1945

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

tippmar-nr
Copy link
Member

Changes the metric harvest override to 10 seconds instead of 5 and introduces a delay after exercising the app but before looking for metric harvest. These changes should help resolve flakiness in the linux smoke tests.

Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is our goal to test the harvest cycles, or would it be better to use SendDataOnExit?

@nrcventura
Copy link
Member

Is our goal to test the harvest cycles, or would it be better to use SendDataOnExit?

The test is already using the SendDataOnExit setting. In one of the recent failures, the shutdown process was able to send all of the data except for the metrics, which caused the test fail.

@tippmar-nr tippmar-nr merged commit e3f12cd into main Oct 4, 2023
@tippmar-nr tippmar-nr deleted the ci/linux-smoke-test-tweaks branch October 4, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants