-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new span attributes to more closely match OTel spec #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chynesNR
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
tippmar-nr and
dotnet-agent-team-bot
October 13, 2023 19:41
tippmar-nr
reviewed
Oct 13, 2023
src/Agent/NewRelic/Agent/Extensions/NewRelic.Agent.Extensions/Providers/Wrapper/Constants.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
nrcventura
reviewed
Oct 13, 2023
nrcventura
reviewed
Oct 13, 2023
nrcventura
reviewed
Oct 13, 2023
src/Agent/NewRelic/Agent/Extensions/NewRelic.Agent.Extensions/Providers/Wrapper/Constants.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1976 +/- ##
==========================================
+ Coverage 83.52% 83.60% +0.08%
==========================================
Files 402 402
Lines 24593 24728 +135
==========================================
+ Hits 20541 20675 +134
- Misses 4052 4053 +1
|
nrcventura
reviewed
Oct 17, 2023
src/Agent/NewRelic/Agent/Core/Wrapper/AgentWrapperApi/Data/MethodCallData.cs
Show resolved
Hide resolved
nrcventura
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was trickier than first expected for a few reasons:
server.address
andserver.port
attributes, but they're optional for database calls (making them Agent attributes) and required for HTTP requests (making them Intrinsic attributes)Resolves #1942
Author Checklist
Reviewer Checklist